mptcp: Avoid NULL dereference in mptcp_getsockopt_subflow_addrs()
authorTim Gardner <tim.gardner@canonical.com>
Fri, 15 Oct 2021 23:05:50 +0000 (16:05 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 16 Oct 2021 07:46:08 +0000 (08:46 +0100)
commit29211e7db28ab12a4a5aaab4bcc080a3ac67ec78
tree1030d561b6b8dedc2703c3916fedee00609a04c8
parent295711fa8fec42a55623bf6997d05a21d7855132
mptcp: Avoid NULL dereference in mptcp_getsockopt_subflow_addrs()

Coverity complains of a possible NULL dereference in
mptcp_getsockopt_subflow_addrs():

 861       } else if (sk->sk_family == AF_INET6) {
     3. returned_null: inet6_sk returns NULL. [show details]
     4. var_assigned: Assigning: np = NULL return value from inet6_sk.
 862                const struct ipv6_pinfo *np = inet6_sk(sk);

Fix this by checking for NULL.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/231
Fixes: c11c5906bc0a ("mptcp: add MPTCP_SUBFLOW_ADDRS getsockopt support")
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
[mjm: Added WARN_ON_ONCE() to the unexpected case]
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/sockopt.c