mei: bus: type promotion bug in mei_nfc_if_version()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 11 Jul 2018 12:29:31 +0000 (15:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Sep 2018 06:38:14 +0000 (08:38 +0200)
commit29068d29718f0bdef2cb98e587e717496e81cbcc
tree3a872aa864aa69857307b9a952dd01494e4cf7af
parent0eb82af7cd718652ed9e18c00352bed33c270ace
mei: bus: type promotion bug in mei_nfc_if_version()

commit b40b3e9358fbafff6a4ba0f4b9658f6617146f9c upstream.

We accidentally removed the check for negative returns
without considering the issue of type promotion.
The "if_version_length" variable is type size_t so if __mei_cl_recv()
returns a negative then "bytes_recv" is type promoted
to a high positive value and treated as success.

Cc: <stable@vger.kernel.org>
Fixes: 582ab27a063a ("mei: bus: fix received data size check in NFC fixup")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/bus-fixup.c