ACPICA: Hardware: Fix a resource leak issue in acpi_hw_build_pci_list().
authorLv Zheng <lv.zheng@intel.com>
Thu, 21 May 2015 02:31:12 +0000 (10:31 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 22 May 2015 01:22:20 +0000 (03:22 +0200)
commit2900d56ffb3bd23646db0d2562b6483329632e8a
tree54472615b1fb0ef5ed7a6df86e48668062b8c0bd
parentc8dec7459d9fcb880e5c42929d01c308bea9f823
ACPICA: Hardware: Fix a resource leak issue in acpi_hw_build_pci_list().

ACPICA commit e4f0b73c107680841d7dd01cc04ec108df6580bd

There is code in acpi_hw_build_pci_list() destructing returned object
(return_list_head) before touching it while the allocated new object
(list_head) is not tracked correctly to be destructed on the error case,
which is detected as unsecure code by the "Coverity" tool.

This patch fixes this issue by always intializing the returned object in
acpi_hw_build_pci_list() so that the caller of acpi_hw_build_pci_list() needn't
initialize it and always using the returned object to track the new
allocated objects. Lv Zheng.

Link: https://github.com/acpica/acpica/commit/e4f0b73c
Link: https://jira01.devtools.intel.com/browse/LCK-2143
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/acpica/hwpci.c