locking/qrwlock: Cleanup queued_write_lock_slowpath()
authorWaiman Long <longman@redhat.com>
Mon, 26 Apr 2021 18:50:17 +0000 (14:50 -0400)
committerPeter Zijlstra <peterz@infradead.org>
Thu, 6 May 2021 13:33:49 +0000 (15:33 +0200)
commit28ce0e70ecc30cc7d558a0304e6b816d70848f9a
treecf69b286807b78a02a43efbca299420f57cdef1b
parent1139aeb1c521eb4a050920ce6c64c36c4f2a3ab7
locking/qrwlock: Cleanup queued_write_lock_slowpath()

Make the code more readable by replacing the atomic_cmpxchg_acquire()
by an equivalent atomic_try_cmpxchg_acquire() and change atomic_add()
to atomic_or().

For architectures that use qrwlock, I do not find one that has an
atomic_add() defined but not an atomic_or().  I guess it should be fine
by changing atomic_add() to atomic_or().

Note that the previous use of atomic_add() isn't wrong as only one
writer that is the wait_lock owner can set the waiting flag and the
flag will be cleared later on when acquiring the write lock.

Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/r/20210426185017.19815-1-longman@redhat.com
kernel/locking/qrwlock.c