scsi: target: Fix XCOPY NAA identifier lookup
authorDavid Disseldorp <ddiss@suse.de>
Tue, 3 Nov 2020 01:21:58 +0000 (02:21 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 11 Jan 2021 22:06:48 +0000 (17:06 -0500)
commit2896c93811e39d63a4d9b63ccf12a8fbc226e5e4
treecd8db4e327c6d581eada6b15661345939bc654bf
parente71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
scsi: target: Fix XCOPY NAA identifier lookup

When attempting to match EXTENDED COPY CSCD descriptors with corresponding
se_devices, target_xcopy_locate_se_dev_e4() currently iterates over LIO's
global devices list which includes all configured backstores.

This change ensures that only initiator-accessible backstores are
considered during CSCD descriptor lookup, according to the session's
se_node_acl LUN list.

To avoid LUN removal race conditions, device pinning is changed from being
configfs based to instead using the se_node_acl lun_ref.

Reference: CVE-2020-28374
Fixes: cbf031f425fd ("target: Add support for EXTENDED_COPY copy offload emulation")
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_xcopy.c
drivers/target/target_core_xcopy.h