stdbuf: avoid even the appearance of a possible use-after-free
authorJim Meyering <meyering@redhat.com>
Fri, 18 Feb 2011 22:29:14 +0000 (23:29 +0100)
committerJim Meyering <meyering@redhat.com>
Fri, 18 Feb 2011 22:31:29 +0000 (23:31 +0100)
commit2895f44e891472c8e86a87989e0e2d41585b006f
tree9f7c597be4dd41eba44a1e7ecf92ed1cb1729b19
parente6067bcb040f110238bd7cbf9f3781f2e149e0c0
stdbuf: avoid even the appearance of a possible use-after-free

There was an execution path by which "libstdbuf" could be used after
being freed, but that would happen only if there were no libstdbuf.so
alongside the stdbuf program and there had been an installation error
leading to absence of the file, PKGLIBDIR/libstdbuf.so.
* src/stdbuf.c (set_LD_PRELOAD): Rearrange loop to make it perfectly
clear that there is no possibility of use-after-free.
Steve Grubb reported this possible use-after-free of "libstdbuf".
src/stdbuf.c