blk-mq: always allow reserved allocation in hctx_may_queue
authorMing Lei <ming.lei@redhat.com>
Fri, 11 Sep 2020 10:41:14 +0000 (18:41 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 11 Sep 2020 11:26:19 +0000 (05:26 -0600)
commit285008501c65a3fcee05d2c2c26cbf629ceff2f0
treec93edb67935d4dcde37c42660ea74eadce19fda5
parent84ed2573c5427de47c71a69d8b0a18020d5f6dd5
blk-mq: always allow reserved allocation in hctx_may_queue

NVMe shares tagset between fabric queue and admin queue or between
connect_q and NS queue, so hctx_may_queue() can be called to allocate
request for these queues.

Tags can be reserved in these tagset. Before error recovery, there is
often lots of in-flight requests which can't be completed, and new
reserved request may be needed in error recovery path. However,
hctx_may_queue() can always return false because there is too many
in-flight requests which can't be completed during error handling.
Finally, nothing can proceed.

Fix this issue by always allowing reserved tag allocation in
hctx_may_queue(). This is reasonable because reserved tags are supposed
to always be available.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: David Milburn <dmilburn@redhat.com>
Cc: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-tag.c
block/blk-mq.c