octeon_ep: cancel tx_timeout_task later in remove sequence
authorMichal Schmidt <mschmidt@redhat.com>
Thu, 10 Aug 2023 15:01:12 +0000 (17:01 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Aug 2023 02:08:13 +0000 (19:08 -0700)
commit28458c80006bb4e993a09fc094094a8578cad292
treebb070b38921dec7c91187ead8b35db0eb87ace2b
parent519b227904f0e70d4a1d6cf41daa5392715f2d2f
octeon_ep: cancel tx_timeout_task later in remove sequence

tx_timeout_task is canceled too early when removing the driver. Nothing
prevents .ndo_tx_timeout from triggering and queuing the work again.

Better cancel it after the netdev is unregistered.
It's harmless for octep_tx_timeout_task to run in the window between the
unregistration and cancelation, because it checks netif_running.

Fixes: 862cd659a6fb ("octeon_ep: Add driver framework and device initialization")
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Link: https://lore.kernel.org/r/20230810150114.107765-3-mschmidt@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeon_ep/octep_main.c