Revert of Disable tail calls inside Simple GM functions. (patchset #1 id:1 of https...
authormtklein <mtklein@google.com>
Thu, 9 Jun 2016 19:20:25 +0000 (12:20 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 9 Jun 2016 19:20:25 +0000 (12:20 -0700)
commit2843c42e594bf45f48a29f4195ec39aeeb92b2bc
tree41203f3cb9dbac5f0b15d7457c17608c45c69d8d
parente239547269c7e6677a7ed6ecdf67234fda662427
Revert of Disable tail calls inside Simple GM functions. (patchset #1 id:1 of https://codereview.chromium.org/2050473006/ )

Reason for revert:
Appears to have broken Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug

Original issue's description:
> Disable tail calls inside Simple GM functions.
>
> I haven't found any way to turn off the particular optimization (-foptimize-sibling-calls)
> per-function, but I can control optimization settings coarsely:
>
>    - on GCC, we can pick a particular -O level, so I've picked -O1 which does not
>      enable -foptimize-sibling-calls
>    - on Clang, we can only disable all optimization for a function
>    - have no idea about MSVC
>
> This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(),
> show up on stack traces when we crash.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050473006
>
> Committed: https://skia.googlesource.com/skia/+/eee3ced68f787aadc47fa274ca8e13b354ec920a

TBR=reed@google.com,mtklein@chromium.org
BUG=skia:

CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug-Trybot

Review-Url: https://codereview.chromium.org/2051193002
gm/gm.h