sched: Fix the check of nr_running at queue wakelist
authorTianchen Ding <dtcccc@linux.alibaba.com>
Wed, 8 Jun 2022 23:34:11 +0000 (07:34 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 13 Jun 2022 08:30:01 +0000 (10:30 +0200)
commit28156108fecb1f808b21d216e8ea8f0d205a530c
tree00eeddc6d084d0059f632d9c7b7bebb4ace1839c
parent792b9f65a568f48c50b3175536db9cde5a1edcc0
sched: Fix the check of nr_running at queue wakelist

The commit 2ebb17717550 ("sched/core: Offload wakee task activation if it
the wakee is descheduling") checked rq->nr_running <= 1 to avoid task
stacking when WF_ON_CPU.

Per the ordering of writes to p->on_rq and p->on_cpu, observing p->on_cpu
(WF_ON_CPU) in ttwu_queue_cond() implies !p->on_rq, IOW p has gone through
the deactivate_task() in __schedule(), thus p has been accounted out of
rq->nr_running. As such, the task being the only runnable task on the rq
implies reading rq->nr_running == 0 at that point.

The benchmark result is in [1].

[1] https://lore.kernel.org/all/e34de686-4e85-bde1-9f3c-9bbc86b38627@linux.alibaba.com/

Suggested-by: Valentin Schneider <vschneid@redhat.com>
Signed-off-by: Tianchen Ding <dtcccc@linux.alibaba.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Link: https://lore.kernel.org/r/20220608233412.327341-2-dtcccc@linux.alibaba.com
kernel/sched/core.c