clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe
authorZhanhao Hu <zero12113@hust.edu.cn>
Thu, 1 Jun 2023 03:38:25 +0000 (03:38 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Jul 2023 14:21:29 +0000 (16:21 +0200)
commit280a5ff665e12d1e0c54c20cedc9c5008aa686a5
tree032070034ac6521e38680d002f5dd7497539bd28
parent9ba3693b0350b154fdd7830559bbc7b04c067096
clk: imx93: fix memory leak and missing unwind goto in imx93_clocks_probe

[ Upstream commit e02ba11b457647050cb16e7cad16cec3c252fade ]

In function probe(), it returns directly without unregistered hws
when error occurs.

Fix this by adding 'goto unregister_hws;' on line 295 and
line 310.

Use devm_kzalloc() instead of kzalloc() to automatically
free the memory using devm_kfree() when error occurs.

Replace of_iomap() with devm_of_iomap() to automatically
handle the unused ioremap region and delete 'iounmap(anatop_base);'
in unregister_hws.

Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk")
Signed-off-by: Zhanhao Hu <zero12113@hust.edu.cn>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20230601033825.336558-1-zero12113@hust.edu.cn
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/imx/clk-imx93.c