iscsi-target: chap auth shouldn't match username with trailing garbage
authorEric Seppanen <eric@purestorage.com>
Wed, 20 Nov 2013 22:19:52 +0000 (14:19 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Dec 2013 18:50:28 +0000 (10:50 -0800)
commit27c0008c75ddfa759d5645ecbc3f86e0de37472a
treee9fde1aec4d5fb1de9ca537767279e698a8526b9
parent7dac7f101e7b6e5b1dd5164cba7cf7268311e13e
iscsi-target: chap auth shouldn't match username with trailing garbage

commit 86784c6bdeeef78eed94d298be7a8879f6a97ee2 upstream.

In iSCSI negotiations with initiator CHAP enabled, usernames with
trailing garbage are permitted, because the string comparison only
checks the strlen of the configured username.

e.g. "usernameXXXXX" will be permitted to match "username".

Just check one more byte so the trailing null char is also matched.

Signed-off-by: Eric Seppanen <eric@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/iscsi/iscsi_target_auth.c