[SourceMgr][FileCheck] Obey -color by extending WithColor
authorJoel E. Denny <jdenny.ornl@gmail.com>
Mon, 22 Oct 2018 18:00:49 +0000 (18:00 +0000)
committerJoel E. Denny <jdenny.ornl@gmail.com>
Mon, 22 Oct 2018 18:00:49 +0000 (18:00 +0000)
commit279f8a44a1fc508ca041efc67e51f32ae76d58f6
tree15525e1c2a8e1bccd5d4b95a95f5837a03617a79
parent49a34dda9cf48df433fea7256570a9ee2312af95
[SourceMgr][FileCheck] Obey -color by extending WithColor

While this change specifically targets FileCheck, it affects any tool
using the same SourceMgr facilities.

Previously, -color was documented in FileCheck's -help output, but
-color had no effect.  Now, -color obeys its documentation: it forces
colors to be used in FileCheck diagnostics even when stderr is not a
terminal.

-color is especially helpful when combined with FileCheck's -v, which
can produce a long series of diagnostics that you might wish to pipe
to a pager, such as less -R.  The WithColor extensions here will also
help to clean up color usage in FileCheck's annotated dump of input,
which is proposed in D52999.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D53419

llvm-svn: 344930
llvm/docs/CommandGuide/FileCheck.rst
llvm/include/llvm/Support/WithColor.h
llvm/lib/Support/SourceMgr.cpp
llvm/lib/Support/WithColor.cpp
llvm/test/FileCheck/opt-color.txt [new file with mode: 0644]