Add an assertion to deleteLater() before it modifies QEvent::d
authorThiago Macieira <thiago.macieira@intel.com>
Wed, 11 Apr 2012 14:25:38 +0000 (11:25 -0300)
committerQt by Nokia <qt-info@nokia.com>
Thu, 19 Apr 2012 10:14:30 +0000 (12:14 +0200)
commit275945f1449b3ff4e7421ab65a38b885cb338152
tree7d8620c20fc5933523b07604e6210298cf63d7a5
parentff55d64f6788563a6ef9da2b6d0b6dc23bb936aa
Add an assertion to deleteLater() before it modifies QEvent::d

The deferred deletion functionality stores the event loop level
nesting count in the QEvent d pointer. In Qt 4, this d pointer was
not usable because we forgot to add a proper copy constructor and
assignment operator to it, so the deleteLater() process stored the
count here safely.

Since Qt 5 now has non-implicit copy methods, the d pointer could be
used in the future. If QEvent uses it, this assertion will
trigger. Note that it doesn't apply to classes derived from QEvent,
though.

Change-Id: I8600c8e9379921e32aca166bc0a6c0b4c4ed799f
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
src/corelib/kernel/qcoreapplication.cpp