media: atomisp: gc0310: Fix double free in gc0310_remove()
authorHans de Goede <hdegoede@redhat.com>
Thu, 18 May 2023 14:15:07 +0000 (15:15 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 9 Jun 2023 13:57:12 +0000 (14:57 +0100)
commit2746a966f9f05fdb0727f4e1e8f2d51ec79e071d
treed8a3653765161eed08c977756b4c3da6f36f1bde
parent76d2d7d6afae2fe5bd7f8e441e9944c6ac8f10dc
media: atomisp: gc0310: Fix double free in gc0310_remove()

gc0310_remove() must not call kfree(dev) since the gc0310_device struct
is devm managed so explicitly freeing it causes a double free.

While at it add a missing mutex_destroy() call for the input_lock.

Link: https://lore.kernel.org/r/20230518153214.194976-6-hdegoede@redhat.com
Fixes: 340b4dd6c183 ("media: atomisp: gc0310: Use devm_kzalloc() for data struct")
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c