crypto: hisilicon/zip - fix mismatch in get/set sgl_sge_nr
authorYe Weihua <yeweihua4@huawei.com>
Thu, 28 Jul 2022 02:07:58 +0000 (10:07 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:35:24 +0000 (12:35 +0200)
commit272093471305261c4e07a2fc97c2d1e53cd56819
tree3be7dc2b49cea8aed03ddfb1cb902c64fddd4ee2
parente0b4ebf598345beec6b6916b2921bde4b05902ae
crypto: hisilicon/zip - fix mismatch in get/set sgl_sge_nr

[ Upstream commit d74f9340097a881869c4c22ca376654cc2516ecc ]

KASAN reported this Bug:

[17619.659757] BUG: KASAN: global-out-of-bounds in param_get_int+0x34/0x60
[17619.673193] Read of size 4 at addr fffff01332d7ed00 by task read_all/1507958
...
[17619.698934] The buggy address belongs to the variable:
[17619.708371]  sgl_sge_nr+0x0/0xffffffffffffa300 [hisi_zip]

There is a mismatch in hisi_zip when get/set the variable sgl_sge_nr.
The type of sgl_sge_nr is u16, and get/set sgl_sge_nr by
param_get/set_int.

Replacing param_get/set_int to param_get/set_ushort can fix this bug.

Fixes: f081fda293ffb ("crypto: hisilicon - add sgl_sge_nr module param for zip")
Signed-off-by: Ye Weihua <yeweihua4@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/hisilicon/zip/zip_crypto.c