tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)
authorPeter Hurley <peter@hurleysoftware.com>
Mon, 11 Jan 2016 06:40:55 +0000 (22:40 -0800)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 15 Feb 2016 20:45:24 +0000 (15:45 -0500)
commit27055738c910ee29a9de4b496e198e17b38b0eed
treea307c4528bb2a00c571f6cff1c4aa4af5057acf5
parent91e65860a7fe55d3d8c150104084b54f2760bc3d
tty: Fix unsafe ldisc reference via ioctl(TIOCGETD)

[ Upstream commit 5c17c861a357e9458001f021a7afa7aab9937439 ]

ioctl(TIOCGETD) retrieves the line discipline id directly from the
ldisc because the line discipline id (c_line) in termios is untrustworthy;
userspace may have set termios via ioctl(TCSETS*) without actually
changing the line discipline via ioctl(TIOCSETD).

However, directly accessing the current ldisc via tty->ldisc is
unsafe; the ldisc ptr dereferenced may be stale if the line discipline
is changing via ioctl(TIOCSETD) or hangup.

Wait for the line discipline reference (just like read() or write())
to retrieve the "current" line discipline id.

Cc: <stable@vger.kernel.org>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/tty/tty_io.c