rtw89: handle potential uninitialized variable
authorPing-Ke Shih <pkshih@realtek.com>
Fri, 18 Mar 2022 03:52:02 +0000 (11:52 +0800)
committerKalle Valo <kvalo@kernel.org>
Wed, 6 Apr 2022 07:50:03 +0000 (10:50 +0300)
commit26bb93407c748d731f25581ccae196e1016072bf
treef2e135a138d37797f6771f72d31a2f92e3fb7382
parent84fc6999f0d01920687d8555e3f1bb87625a66ed
rtw89: handle potential uninitialized variable

The smatch reports:
 rtw8852a.c:1857 rtw8852a_btc_set_wl_txpwr_ctrl() error: uninitialized symbol '_cur'.
 rtw8852a.c:1858 rtw8852a_btc_set_wl_txpwr_ctrl() error: uninitialized symbol '_cur'.

This is because rtw89_mac_txpwr_read32() can possibly return before setting
argument _cur, and the caller will use the uninitialized value. To fix this
problem, check the return value of rtw89_mac_txpwr_read32().

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220318035202.42437-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/rtw8852a.c