[media] media, cx231xx: Fix double free on close
authorJesper Juhl <jj@chaosbits.net>
Sun, 4 Mar 2012 19:25:04 +0000 (16:25 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 19 Mar 2012 17:13:51 +0000 (14:13 -0300)
commit266e8ae37daa04fb3d89759305659f4e0acbc126
treeabe4d6853750453d98050970cccc6352a06f83da
parent1a611d8cd078e0059a4a596bcbed0bd8a915e2ef
[media] media, cx231xx: Fix double free on close

In cx231xx_v4l2_close() there are two calls to
cx231xx_release_resources(dev) followed by kfree(dev). That is a
problem since cx231xx_release_resources() already kfree()'s its
argument, so we end up doing a double free.

Easily resolved by just removing the redundant kfree() calls after the
calls to cx231xx_release_resources().

I also changed the 'dev = NULL' assignments (which are rather
pointless since 'dev' is about to go out of scope), to 'fh->dev = NULL'
since it looks to me that that is what was actually intended.
And I removed the 'dev = NULL' assignment at the end of
cx231xx_release_resources() since it is pointless.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/cx231xx/cx231xx-cards.c
drivers/media/video/cx231xx/cx231xx-video.c