Change tests to not modify Core_Root (dotnet/coreclr#23470)
authorJeremy Koritzinsky <jkoritzinsky@gmail.com>
Tue, 2 Apr 2019 23:39:11 +0000 (16:39 -0700)
committerGitHub <noreply@github.com>
Tue, 2 Apr 2019 23:39:11 +0000 (16:39 -0700)
commit266caebb6cbea95b9355906b6338c09b2e118ab6
treeeed97f24f1245fdcb467941310906f3f3f233f12
parentaa45b2557af5658aeb08ae095fa1c8779a2dec74
Change tests to not modify Core_Root (dotnet/coreclr#23470)

Redesign tests that needed to modify Core_Root to no longer do so.

- Loader.FromNativePaths: Use `CORE_LIBRARIES` instead of `COREROOT`
- Loader.AssemblyDependencyResolver: Split out the invalid hosting test that needs hostpolicy to not be preloaded. Have `CoreRun` and `CoreShim` preload hostpolicy when a path to a hostpolicy is specified in the `MOCK_HOSTPOLICY` environment variable.
- Add a `CLRTest.MockHosting.targets` file that is imported when a test requires hostpolicy. It adds the reference to the mock hostpolicy and ensures that the `MOCK_HOSTPOLICY` environment variable is correctly set in the test scripts.

Fixes dotnet/coreclr#23429.

Commit migrated from https://github.com/dotnet/coreclr/commit/2516a53b75ef74b585cc507e07d39e37675993b9
22 files changed:
src/coreclr/src/coreclr/hosts/corerun/corerun.cpp
src/coreclr/src/coreclr/hosts/coreshim/CoreShim.cpp
src/coreclr/src/coreclr/hosts/unixcoreruncommon/coreruncommon.cpp
src/coreclr/tests/src/CLRTest.Execute.Bash.targets
src/coreclr/tests/src/CLRTest.Execute.targets
src/coreclr/tests/src/CLRTest.MockHosting.targets [new file with mode: 0644]
src/coreclr/tests/src/Common/CoreCLRTestLibrary/HostPolicyMock.cs
src/coreclr/tests/src/Interop/COM/Activator/Activator.csproj
src/coreclr/tests/src/Interop/COM/NativeClients/DefaultInterfaces.csproj
src/coreclr/tests/src/Interop/COM/NativeClients/Licensing.csproj
src/coreclr/tests/src/Interop/COM/NativeClients/Primitives.csproj
src/coreclr/tests/src/Interop/IJW/LoadIjwFromModuleHandle/LoadIjwFromModuleHandle.csproj
src/coreclr/tests/src/Interop/Interop.settings.targets
src/coreclr/tests/src/Loader/AssemblyDependencyResolver/AssemblyDependencyResolverTests/AssemblyDependencyResolverTests.cs [moved from src/coreclr/tests/src/Loader/AssemblyDependencyResolverTests/AssemblyDependencyResolverTests.cs with 97% similarity]
src/coreclr/tests/src/Loader/AssemblyDependencyResolver/AssemblyDependencyResolverTests/AssemblyDependencyResolverTests.csproj [moved from src/coreclr/tests/src/Loader/AssemblyDependencyResolverTests/AssemblyDependencyResolverTests.csproj with 70% similarity]
src/coreclr/tests/src/Loader/AssemblyDependencyResolver/AssemblyDependencyResolverTests/NativeDependencyTests.cs [moved from src/coreclr/tests/src/Loader/AssemblyDependencyResolverTests/NativeDependencyTests.cs with 100% similarity]
src/coreclr/tests/src/Loader/AssemblyDependencyResolver/AssemblyDependencyResolverTests/TestBase.cs [moved from src/coreclr/tests/src/Loader/AssemblyDependencyResolverTests/TestBase.cs with 100% similarity]
src/coreclr/tests/src/Loader/AssemblyDependencyResolver/MissingHostPolicyTests/InvalidHostingTest.cs [new file with mode: 0644]
src/coreclr/tests/src/Loader/AssemblyDependencyResolver/MissingHostPolicyTests/MissingHostPolicyTests.csproj [new file with mode: 0644]
src/coreclr/tests/src/Loader/AssemblyDependencyResolverTests/InvalidHostingTest.cs [deleted file]
src/coreclr/tests/src/Loader/NativeLibs/FromNativePaths.cs
src/coreclr/tests/src/Loader/NativeLibs/FromNativePaths.csproj