upstream: [media] dvb_demux: fix deadlock in dmx_section_feed_release_filter()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Sat, 9 Nov 2013 21:28:43 +0000 (18:28 -0300)
committerChanho Park <chanho61.park@samsung.com>
Tue, 18 Nov 2014 02:52:17 +0000 (11:52 +0900)
commit266b2a25537ea7ef95f45cca76e36b138ee0dddd
tree124e0e0bc94a9da4587852cfe19aef34d4e7f806
parent05171c52333228cab37786154fbc17c1caee0045
upstream: [media] dvb_demux: fix deadlock in dmx_section_feed_release_filter()

dmx_section_feed_release_filter() locks dvbdmx->mutex and
if the feed is still filtering, it calls feed->stop_filtering(feed).
stop_filtering() is implemented by dmx_section_feed_stop_filtering()
that first of all try to lock the same mutex: dvbdmx->mutex.
That leads to a deadlock.
It does not happen often in practice because all callers of
release_filter() stop filtering by themselves.
So the problem can happen in case of race condition only.
The patch releases dvbdmx->mutex before call to feed->stop_filtering(feed)
and reacquires the mutex after that.
Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/dvb-core/dvb_demux.c