usermodehelper: check subprocess_info->path != NULL
authorOleg Nesterov <oleg@redhat.com>
Thu, 16 May 2013 15:43:55 +0000 (17:43 +0200)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 16 May 2013 19:01:11 +0000 (12:01 -0700)
commit264b83c07a84223f0efd0d1db9ccc66d6f88288f
tree509dd304b80cf3d53f03c03fcbbc99d05fec7924
parent5c64e3a45d43c6e3fa87cbe02e10059171d10812
usermodehelper: check subprocess_info->path != NULL

argv_split(empty_or_all_spaces) happily succeeds, it simply returns
argc == 0 and argv[0] == NULL. Change call_usermodehelper_exec() to
check sub_info->path != NULL to avoid the crash.

This is the minimal fix, todo:

 - perhaps we should change argv_split() to return NULL or change the
   callers.

 - kill or justify ->path[0] check

 - narrow the scope of helper_lock()

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-By: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/kmod.c