misc: st_core: Error triggered by convert "char" to "int"
authorchanning <chao.bi@intel.com>
Thu, 10 Jan 2013 08:27:29 +0000 (16:27 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 18:19:42 +0000 (10:19 -0800)
commit25c22d5bead5b0211f3ecc84fd6152dfdf95c75d
tree438db8f8c22d2247d6179cf003a56ecf17573e68
parent867ff9880d5d71a38433c0471bc09bcc10851f36
misc: st_core: Error triggered by convert "char" to "int"

When st driver decodes protocol index received from raw data,
it does a value convert from "char" to "int". Because it's sign
extension from bit8 to bit32, the "int" value maybe minus, in
another word, the protocol index might be minus, but driver doesn't
filter such case and may continue access memory pointed by this
minus index.

This patch is to change the variable type of index from "int"
to "unsigned char", so that it avoids do such kind of type
conversion.

cc: liu chuansheng <chuansheng.liu@intel.com>
Signed-off-by: channing <chao.bi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/ti-st/st_core.c