scsi: ibmvfc: Protect vhost->task_set increment by the host lock
authorBrian King <brking@linux.vnet.ibm.com>
Wed, 16 Sep 2020 20:09:59 +0000 (15:09 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 22 Sep 2020 21:38:39 +0000 (17:38 -0400)
commit2584e5aef87a921fc4bf23e2d2ea98c5277f0a0f
tree12715dfa693a5a27e853f31ac25eba42083ca3c7
parent3c9a7c58ea3d8a9d2f7377db3fdb9d7b4da1d480
scsi: ibmvfc: Protect vhost->task_set increment by the host lock

In the discovery thread, ibmvfc does a vhost->task_set++ without any lock
held. This could result in two targets getting the same cancel key, which
could have strange effects in error recovery.  The actual probability of
this occurring should be extremely small, since this should all be done in
a single threaded loop from the discovery thread, but let's fix it up
anyway to be safe.

Link: https://lore.kernel.org/r/1600286999-22059-1-git-send-email-brking@linux.vnet.ibm.com
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ibmvscsi/ibmvfc.c