netfilter: nf_log: replace BUG_ON by WARN_ON_ONCE when putting logger
authorPablo Neira Ayuso <pablo@netfilter.org>
Mon, 29 Jan 2024 10:09:43 +0000 (11:09 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:14:36 +0000 (20:14 +0000)
commit25621b53377d62ee96827a0a5ed97135f86ad1a7
tree01535897046d1e39e38aa57bae5990dc6dd7f9a1
parentce76746a1cd281dc49b8faaf4afe742efe01dd3b
netfilter: nf_log: replace BUG_ON by WARN_ON_ONCE when putting logger

[ Upstream commit 259eb32971e9eb24d1777a28d82730659f50fdcb ]

Module reference is bumped for each user, this should not ever happen.

But BUG_ON check should use rcu_access_pointer() instead.

If this ever happens, do WARN_ON_ONCE() instead of BUG_ON() and
consolidate pointer check under the rcu read side lock section.

Fixes: fab4085f4e24 ("netfilter: log: nf_log_packet() as real unified interface")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/netfilter/nf_log.c