net: fix possible store tearing in neigh_periodic_work()
authorEric Dumazet <edumazet@google.com>
Thu, 21 Sep 2023 08:46:26 +0000 (08:46 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 1 Oct 2023 15:29:06 +0000 (16:29 +0100)
commit25563b581ba3a1f263a00e8c9a97f5e7363be6fd
treeb3564a6168f019dd55288ea76dc481d2b2c04832
parentc15cd642d437c9f64d397c14ce734e0554d3977b
net: fix possible store tearing in neigh_periodic_work()

While looking at a related syzbot report involving neigh_periodic_work(),
I found that I forgot to add an annotation when deleting an
RCU protected item from a list.

Readers use rcu_deference(*np), we need to use either
rcu_assign_pointer() or WRITE_ONCE() on writer side
to prevent store tearing.

I use rcu_assign_pointer() to have lockdep support,
this was the choice made in neigh_flush_dev().

Fixes: 767e97e1e0db ("neigh: RCU conversion of struct neighbour")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/neighbour.c