Avoid using QSKIP in lieu of compile-time checks
authorJason McDonald <jason.mcdonald@nokia.com>
Tue, 4 Oct 2011 03:23:23 +0000 (13:23 +1000)
committerQt by Nokia <qt-info@nokia.com>
Wed, 5 Oct 2011 04:15:00 +0000 (06:15 +0200)
commit253497b7446c7d723aa3bdd7152e25d6852f2604
treee91eb9fdb94aae121fa587ab5f54f3917a6c1d55
parent3f88da82b1bdf79fe4c89640838b0b69c8a89d8b
Avoid using QSKIP in lieu of compile-time checks

QSKIP is intended to be used to skip test functions that are found at
run-time to be inapplicable or unsafe.  If a test function can be
determined to be inapplicable at compile-time, the entire test function
should be omitted instead of replacing the body of the test function
with a QSKIP, which only serves to slow down test runs and to inflate
test run-rates with empty, inapplicable tests.

Task-number: QTQAINFRA-278

Change-Id: I582732e3dd657df834f9a98fd52d7ee368f2f29b
Reviewed-on: http://codereview.qt-project.org/5946
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
26 files changed:
tests/auto/collections/tst_collections.cpp
tests/auto/networkselftest/tst_networkselftest.cpp
tests/auto/qcombobox/tst_qcombobox.cpp
tests/auto/qdialog/tst_qdialog.cpp
tests/auto/qdirectpainter/tst_qdirectpainter.cpp
tests/auto/qdirmodel/tst_qdirmodel.cpp
tests/auto/qfiledialog/tst_qfiledialog.cpp
tests/auto/qfocusevent/tst_qfocusevent.cpp
tests/auto/qgraphicsgridlayout/tst_qgraphicsgridlayout.cpp
tests/auto/qgraphicslinearlayout/tst_qgraphicslinearlayout.cpp
tests/auto/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp
tests/auto/qgraphicsscene/tst_qgraphicsscene.cpp
tests/auto/qgraphicsview/tst_qgraphicsview.cpp
tests/auto/qlabel/tst_qlabel.cpp
tests/auto/qlineedit/tst_qlineedit.cpp
tests/auto/qmainwindow/tst_qmainwindow.cpp
tests/auto/qmdisubwindow/tst_qmdisubwindow.cpp
tests/auto/qmenu/tst_qmenu.cpp
tests/auto/qmenubar/tst_qmenubar.cpp
tests/auto/qmessagebox/tst_qmessagebox.cpp
tests/auto/qscroller/tst_qscroller.cpp
tests/auto/qstyle/tst_qstyle.cpp
tests/auto/qtableview/tst_qtableview.cpp
tests/auto/qwidget_window/tst_qwidget_window.cpp
tests/auto/tools/moc/tst_moc.cpp
tests/auto/xml/sax/qxml/tst_qxml.cpp