virtio-net: fix race between set queues and probe
authorJason Wang <jasowang@redhat.com>
Tue, 25 Jul 2023 07:20:49 +0000 (03:20 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 27 Jul 2023 05:09:42 +0000 (22:09 -0700)
commit25266128fe16d5632d43ada34c847d7b8daba539
tree8b76692de2e1046986ffbafb4a9052b9f3da0c66
parent6c58c8816abb7b93b21fa3b1d0c1726402e5e568
virtio-net: fix race between set queues and probe

A race were found where set_channels could be called after registering
but before virtnet_set_queues() in virtnet_probe(). Fixing this by
moving the virtnet_set_queues() before netdevice registering. While at
it, use _virtnet_set_queues() to avoid holding rtnl as the device is
not even registered at that time.

Cc: stable@vger.kernel.org
Fixes: a220871be66f ("virtio-net: correctly enable multiqueue")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230725072049.617289-1-jasowang@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/virtio_net.c