[flang] Simplify Semantics::Perform
authorTim Keith <tkeith@nvidia.com>
Thu, 7 Mar 2019 01:07:25 +0000 (17:07 -0800)
committerTim Keith <tkeith@nvidia.com>
Thu, 7 Mar 2019 01:07:25 +0000 (17:07 -0800)
commit251e0196e4b4eb1ac2e58d3d20232cc34902072c
tree3102aee3522d91aa0e0829fb7e3b0dddf999d7ee
parentc1970da2396547566db794ffb5a05d3e9dd2755d
[flang] Simplify Semantics::Perform

`Semantics::Perform` is mostly a series of calls followed by a check
for fatal errors. There is more error checking logic than real code.

To make it clearer, change each of the phases it calls to return true
on success so that `Perform` can just call them one after the other.

Original-commit: flang-compiler/f18@a218cac788fdc4018645651964e75221c6f31653
Reviewed-on: https://github.com/flang-compiler/f18/pull/317
flang/lib/semantics/canonicalize-do.cc
flang/lib/semantics/canonicalize-do.h
flang/lib/semantics/mod-file.cc
flang/lib/semantics/mod-file.h
flang/lib/semantics/resolve-names.cc
flang/lib/semantics/resolve-names.h
flang/lib/semantics/rewrite-parse-tree.cc
flang/lib/semantics/rewrite-parse-tree.h
flang/lib/semantics/semantics.cc