clk: pxa: fix pxa2xx_determine_rate return
authorArnd Bergmann <arnd@arndb.de>
Tue, 8 Nov 2016 14:49:31 +0000 (15:49 +0100)
committerStephen Boyd <sboyd@codeaurora.org>
Wed, 9 Nov 2016 20:04:33 +0000 (12:04 -0800)
commit2517b32bd9e178b0701f18f9ae8cc043f464dcea
treeb1bd66db9e66ba8146f39ad43999746d0a3110fa
parent8c1ee96a2febee5a1dfb0e9d96c8f28a98f0a16b
clk: pxa: fix pxa2xx_determine_rate return

The new pxa2xx_determine_rate() function seems lacking in a few
regards:

- For an exact match or no match at all, the rate is uninitialized
  as reported by gcc -Wmaybe-unintialized:
   drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_determine_rate':
   drivers/clk/pxa/clk-pxa.c:243:5: error: 'rate' may be used uninitialized in this function

- If we get a non-exact match, the req->rate output is never set
  to the actual rate but remains at the requested rate.

- We should not attempt to print a rate if none could be found

This rewrites the logic accordingly.

Fixes: 9fe694295098 ("clk: pxa: transfer CPU clock setting from pxa2xx-cpufreq")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/pxa/clk-pxa.c