scsi: ufs: Replace all non-returning strlcpy() with strscpy()
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Tue, 30 May 2023 16:41:31 +0000 (16:41 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 31 May 2023 22:06:54 +0000 (18:06 -0400)
commit2516cb882295694623811f2a1b2d33aa5fc9139c
tree7f17dbafcf8146f85dec4c41c97ea84efc3ca178
parent41e5d6f64d76435b4fd6856ddddb8e7c62087333
scsi: ufs: Replace all non-returning strlcpy() with strscpy()

strlcpy() reads the entire source buffer first.  This read may exceed the
destination size limit.  This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1].  In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Link: https://lore.kernel.org/r/20230530164131.987213-1-azeemshaikh38@gmail.com
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufs-fault-injection.c