ASoC: soc-dpcm.h: remove snd_soc_dpcm::hw_param
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Wed, 19 Oct 2022 00:37:26 +0000 (00:37 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 19 Oct 2022 12:05:34 +0000 (13:05 +0100)
commit25106550f1366bec8a9adefeada5e8ff5205c828
tree3399fb0ddd30a04ed611bf5367e1b1b8814dcb73
parentc670a224d1367f5bb3cc40c6b6b1ba0591b26df9
ASoC: soc-dpcm.h: remove snd_soc_dpcm::hw_param

Current soc-pcm.c is coping fe hw_param to dpcm->hw_param (A),
fixup it (B), and copy it to be (C).

int dpcm_be_dai_hw_params(...)
{
...
for_each_dpcm_be(fe, stream, dpcm) {
...
/* copy params for each dpcm */
(A) memcpy(&dpcm->hw_params, &fe->dpcm[stream].hw_params, ...) ;

/* perform any hw_params fixups */
(B) ret = snd_soc_link_be_hw_params_fixup(be, &dpcm->hw_params);
...

/* copy the fixed-up hw params for BE dai */
(C) memcpy(&be->dpcm[stream].hw_params, &dpcm->hw_params, ...);
...
}
...
}

But here, (1) it is coping hw_params without caring stream (Playback/Capture),
(2) we can get same value from be. We don't need to have dpcm->hw_params.
This patch removes it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/87v8ogsl6h.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
include/sound/soc-dpcm.h
sound/soc/sh/rcar/core.c
sound/soc/soc-pcm.c