packet: only test po->has_vnet_hdr once in packet_snd
authorWillem de Bruijn <willemb@google.com>
Tue, 26 Sep 2017 16:20:17 +0000 (12:20 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Oct 2017 09:51:22 +0000 (11:51 +0200)
commit24ee394a82d2cd92c92b617713a4d263131a902b
treec85d01dad43a809227211e7a8b5de424d0f5338a
parent0f22167d3321a028c0b6edc2d5b2ab0e37a2ac53
packet: only test po->has_vnet_hdr once in packet_snd

[ Upstream commit da7c9561015e93d10fe6aab73e9288e0d09d65a6 ]

Packet socket option po->has_vnet_hdr can be updated concurrently with
other operations if no ring is attached.

Do not test the option twice in packet_snd, as the value may change in
between calls. A race on setsockopt disable may cause a packet > mtu
to be sent without having GSO options set.

Fixes: bfd5f4a3d605 ("packet: Add GSO/csum offload support.")
Signed-off-by: Willem de Bruijn <willemb@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/packet/af_packet.c