infiniband: avoid dereferencing uninitialized dst on error path
authorPaolo Abeni <pabeni@redhat.com>
Tue, 2 May 2017 14:03:58 +0000 (16:03 +0200)
committerDoug Ledford <dledford@redhat.com>
Tue, 2 May 2017 14:45:45 +0000 (10:45 -0400)
commit24b43c99647bf9be4995e6a6c9c3a923c147770a
tree2318075dcfbd29e3d91ccb9d234473e49f51eaa9
parent87f0faadc68534668802a85ae670435bc90830b3
infiniband: avoid dereferencing uninitialized dst on error path

With commit eea40b8f624f ("infiniband: call ipv6 route lookup
via the stub interface"), if the route lookup fails due to
ipv6 being disabled, the dst variable is left untouched, and
the following dst_release() may access uninitialized memory.

Since ipv6_dst_lookup() always sets dst to NULL in case of
lookup failure with ipv6 enabled, fix the above just
returning the error code if the lookup fails.

Fixes: eea40b8f624 ("infiniband: call ipv6 route lookup via the stub interface")
Reported-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Doug Ledford <dledford@redhat.com>
drivers/infiniband/core/addr.c