projects / platform / core / csapi / xsf.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1f82d07) | patch
[iOS] Fix: memory leak when Navigation.RemovePage is used (#5695)
authorkicsiede <4233752+kicsiede@users.noreply.github.com>
Wed, 8 May 2019 17:41:08 +0000 (19:41 +0200)
committerRui Marinho <me@ruimarinho.net>
Wed, 8 May 2019 17:41:07 +0000 (10:41 -0700)
commit247f758523c8bce9162b0a7192b24b53a9d4ae86
treee213e93e920f0e25c75c2595d4d9e0b9f6f16c7btree | snapshot
parent1f82d07b9bd8c7f0411307a3f81183c48e39dadccommit | diff
[iOS] Fix: memory leak when Navigation.RemovePage is used (#5695)

* Fix: memoryleak when Navigation.RemovePage is used

The leak occurs in a MasterDetailPage.Detail = NavigationPage(ContentPage) scenario if the ContentPage has ToolBarItems. (ToolBarItems create a strong dependency therefore the ViewController of the NavigationPage must be explicitly disposed)

* + unit test

* fix issue attribute
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5695.cs [new file with mode: 0644] blob
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems diff | blob | history
Xamarin.Forms.Platform.iOS/Renderers/NavigationRenderer.cs diff | blob | history
Domain: Dotnet / UI;