block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq
authorYu Kuai <yukuai3@huawei.com>
Mon, 26 Dec 2022 03:06:05 +0000 (11:06 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Dec 2022 19:09:56 +0000 (12:09 -0700)
commit246cf66e300b76099b5dbd3fdd39e9a5dbc53f02
tree710ae2b27578858542cd8aee3e86e8a4d557b650
parentfb857b0bb2c7eea22a896c53c849a75437d24ea8
block, bfq: fix uaf for bfqq in bfq_exit_icq_bfqq

Commit 64dc8c732f5c ("block, bfq: fix possible uaf for 'bfqq->bic'")
will access 'bic->bfqq' in bic_set_bfqq(), however, bfq_exit_icq_bfqq()
can free bfqq first, and then call bic_set_bfqq(), which will cause uaf.

Fix the problem by moving bfq_exit_bfqq() behind bic_set_bfqq().

Fixes: 64dc8c732f5c ("block, bfq: fix possible uaf for 'bfqq->bic'")
Reported-by: Yi Zhang <yi.zhang@redhat.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20221226030605.1437081-1-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c