staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl
authorViktor Slavkovic <viktors@google.com>
Mon, 8 Jan 2018 18:43:03 +0000 (10:43 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Jan 2018 08:45:26 +0000 (09:45 +0100)
commit242e20a5b3cc2b99ace977546d3cffc6a2a35991
tree7ab252d2924509fa25a30331365905722805452b
parent0382becc1d24e1cd00dc44e1fa5f7655441c258c
staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl

commit 443064cb0b1fb4569fe0a71209da7625129fb760 upstream.

A lock-unlock is missing in ASHMEM_SET_SIZE ioctl which can result in a
race condition when mmap is called. After the !asma->file check, before
setting asma->size, asma->file can be set in mmap. That would result in
having different asma->size than the mapped memory size. Combined with
ASHMEM_UNPIN ioctl and shrinker invocation, this can result in memory
corruption.

Signed-off-by: Viktor Slavkovic <viktors@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ashmem.c