cfg80211: validate SSID/MBSSID element ordering assumption
authorJohannes Berg <johannes.berg@intel.com>
Fri, 20 Sep 2019 19:54:18 +0000 (21:54 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 1 Oct 2019 15:56:18 +0000 (17:56 +0200)
commit242b0931c1918c56cd1dc5563fd250a3c39b996d
treeb77f7a1be393914362e12da3a769d8ff0d27746a
parentf88eb7c0d002a67ef31aeb7850b42ff69abc46dc
cfg80211: validate SSID/MBSSID element ordering assumption

The code copying the data assumes that the SSID element is
before the MBSSID element, but since the data is untrusted
from the AP, this cannot be guaranteed.

Validate that this is indeed the case and ignore the MBSSID
otherwise, to avoid having to deal with both cases for the
copy of data that should be between them.

Cc: stable@vger.kernel.org
Fixes: 0b8fb8235be8 ("cfg80211: Parsing of Multiple BSSID information in scanning")
Link: https://lore.kernel.org/r/1569009255-I1673911f5eae02964e21bdc11b2bf58e5e207e59@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/scan.c