projects / platform / upstream / libSkiaSharp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cc190eb) | patch
Make tools/submit_try safer
authorcommit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Thu, 16 Jan 2014 19:48:19 +0000 (19:48 +0000)
committercommit-bot@chromium.org <commit-bot@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81>
Thu, 16 Jan 2014 19:48:19 +0000 (19:48 +0000)
commit240196d751904c4ca89f26730f89404018cc79b7
tree3ee9c8724d34bd2f011677e8ff512494e8370943tree | snapshot
parentcc190eb6f321d0255ca035dc1ceef53af3900f4acommit | diff
Make tools/submit_try safer

Using proc.wait() in combination with PIPE doesn't seem
to be safe for large patches according to
http://docs.python.org/2/library/subprocess.html.

Moving to proc.communicate().

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, borenet@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/141023003

git-svn-id: http://skia.googlecode.com/svn/trunk@13113 2bbb7eff-a529-9590-31e7-b0007b416f81
tools/submit_try diff | blob | history
Domain: Dotnet / API;