Input: ALPS - clean up code for SS5 hardware
authorPaul Donohue <linux-kernel@PaulSD.com>
Tue, 29 Nov 2016 04:16:21 +0000 (20:16 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 29 Nov 2016 04:24:07 +0000 (20:24 -0800)
commit23fce365c6a26e40d459ca97289dd18543fb6845
tree80d5e66a08da765022c63e2645c737bfdf09ba31
parent7229c58c096ca08576cbcbf6669bfbdcae0b5d22
Input: ALPS - clean up code for SS5 hardware

The return value of alps_get_pkt_id_ss4_v2() should really be "enum
SS4_PACKET_ID", not "unsigned char".  Correct this.

Also, most of the Alps SS5 (SS4 v2) packet byte parsing code is implemented
using macros, but there are a few places where bytes are directly
manipulated in alps.c.  For consistency, migrate the rest of these to
macros.

Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Paul Donohue <linux-kernel@PaulSD.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/alps.c
drivers/input/mouse/alps.h