Send QUIT on SmtpClient.Dispose() (#683)
authorMarco Rossignoli <marco.rossignoli@gmail.com>
Wed, 26 Feb 2020 14:23:22 +0000 (15:23 +0100)
committerGitHub <noreply@github.com>
Wed, 26 Feb 2020 14:23:22 +0000 (06:23 -0800)
commit23e388ba40a3438fc50361583d7f8904d7bfa96d
tree1bcc1eea61480332d21ee1b4701a717d54af5ae4
parent955578f1fdd49be1f4a895d7ad4bb8d4eee38707
Send QUIT on SmtpClient.Dispose() (#683)

* send QUIT on Dispose()

* add try/finally

* simplify null check

* address PR feedback

* send quit in non-blocking mode

* resolve conflicts
src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpClient.cs
src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpCommands.cs
src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpConnection.cs
src/libraries/System.Net.Mail/src/System/Net/Mail/SmtpTransport.cs
src/libraries/System.Net.Mail/tests/Functional/SmtpClientTest.cs