PR target/88638 - FAIL: fsf-nsstring-format-1.s on darwin
authorMartin Sebor <msebor@redhat.com>
Mon, 14 Jan 2019 18:44:00 +0000 (18:44 +0000)
committerMartin Sebor <msebor@gcc.gnu.org>
Mon, 14 Jan 2019 18:44:00 +0000 (11:44 -0700)
commit23db6ced33c245c38c147c31011bbafa392e4328
treee0ee52741bfafa1d02673e8cf26b8d54139efe82
parent15f4e33db7e7b0c466db39eccfc693c910459368
PR target/88638 - FAIL: fsf-nsstring-format-1.s on darwin

gcc/c-family/ChangeLog:

PR target/88638
* c-attribs.c (positional_argument): Call valid_format_string_type_p
and issue errors if it fails.
* c-common.h (valid_format_string_type_p): Declare.
* c-format.c (valid_stringptr_type_p): Rename...
(valid_format_string_type_p): ...to this and make extern.
(handle_format_arg_attribute): Adjust to new name.
(check_format_string): Same.

gcc/testsuite/ChangeLog:

PR target/88638
* gcc.dg/format/attr-8.c: New test.
* gcc.dg/darwin-cfstring-format-1.c: Adjust diagnostics.
* gcc.dg/format/attr-3.c: Same.
* obj-c++.dg/fsf-nsstring-format-1.mm: Same.
* objc.dg/fsf-nsstring-format-1.m: Same.

gcc/ChangeLog:

PR target/88638
* doc/extend.texi (Darwin Format Checks): Clarify.

From-SVN: r267922
12 files changed:
gcc/ChangeLog
gcc/c-family/ChangeLog
gcc/c-family/c-attribs.c
gcc/c-family/c-common.h
gcc/c-family/c-format.c
gcc/doc/extend.texi
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.dg/darwin-cfstring-format-1.c
gcc/testsuite/gcc.dg/format/attr-3.c
gcc/testsuite/gcc.dg/format/attr-8.c [new file with mode: 0644]
gcc/testsuite/obj-c++.dg/fsf-nsstring-format-1.mm
gcc/testsuite/objc.dg/fsf-nsstring-format-1.m