selinux: ensure we cleanup the internal AVC counters on error in avc_update()
authorJaihind Yadav <jaihindyadav@codeaurora.org>
Tue, 17 Dec 2019 11:55:47 +0000 (17:25 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Feb 2020 14:42:43 +0000 (15:42 +0100)
commit23a0b5ad57180c74622bd04d249eb95a8e7206f7
tree5c05e3b64fc282912c0402439511d05f77087084
parent217e72075fe5dbda6f7a8f589f5b4ae90d72ff14
selinux: ensure we cleanup the internal AVC counters on error in avc_update()

[ Upstream commit 030b995ad9ece9fa2d218af4429c1c78c2342096 ]

In AVC update we don't call avc_node_kill() when avc_xperms_populate()
fails, resulting in the avc->avc_cache.active_nodes counter having a
false value.  In last patch this changes was missed , so correcting it.

Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
Signed-off-by: Jaihind Yadav <jaihindyadav@codeaurora.org>
Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
[PM: merge fuzz, minor description cleanup]
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
security/selinux/avc.c