irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable
authorLubomir Rintel <lkundrak@v3.sk>
Mon, 28 Jan 2019 15:59:35 +0000 (16:59 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Tue, 29 Jan 2019 15:48:52 +0000 (15:48 +0000)
commit2380a22b60ce6f995eac806e69c66e397b59d045
tree20b6154f202ee6f2e3622df6eb5ae23f25434cdc
parent45725e0fc3e7fe52fedb94f59806ec50e9618682
irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable

Resetting bit 4 disables the interrupt delivery to the "secure
processor" core. This breaks the keyboard on a OLPC XO 1.75 laptop,
where the firmware running on the "secure processor" bit-bangs the
PS/2 protocol over the GPIO lines.

It is not clear what the rest of the bits are and Marvell was unhelpful
when asked for documentation. Aside from the SP bit, there are probably
priority bits.

Leaving the unknown bits as the firmware set them up seems to be a wiser
course of action compared to just turning them off.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
[maz: fixed-up subject and commit message]
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-mmp.c