dm mpath: switch paths in dm_blk_ioctl() code path
authorMartin Wilck <mwilck@suse.com>
Mon, 20 Apr 2020 20:29:09 +0000 (22:29 +0200)
committerMike Snitzer <snitzer@redhat.com>
Fri, 15 May 2020 14:29:35 +0000 (10:29 -0400)
commit2361ae595352dec015d14292f1b539242d8446d6
tree47bc57c7c09db1c151828c6ffe20689dfe46afc0
parent27f5411a718c431c20007e3a2fbba6589942d04f
dm mpath: switch paths in dm_blk_ioctl() code path

SCSI LUN passthrough code such as qemu's "scsi-block" device model
pass every IO to the host via SG_IO ioctls. Currently, dm-multipath
calls choose_pgpath() only in the block IO code path, not in the ioctl
code path (unless current_pgpath is NULL). This has the effect that no
path switching and thus no load balancing is done for SCSI-passthrough
IO, unless the active path fails.

Fix this by using the same logic in multipath_prepare_ioctl() as in
multipath_clone_and_map().

Note: The allegedly best path selection algorithm, service-time,
still wouldn't work perfectly, because the io size of the current
request is always set to 0. Changing that for the IO passthrough
case would require the ioctl cmd and arg to be passed to dm's
prepare_ioctl() method.

Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-mpath.c