drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()
authorZhou Qingyang <zhou1615@umn.edu>
Mon, 24 Jan 2022 16:58:55 +0000 (00:58 +0800)
committerLyude Paul <lyude@redhat.com>
Tue, 25 Jan 2022 22:50:49 +0000 (17:50 -0500)
commit2343bcdb4747d4f418a4daf2e898b94f86c24a59
tree7cc16cf9966e4997dc82f37a9de008f6e96543dd
parent80ecb5d7c0f224218fdf956faec0ebe73d79f53d
drm/nouveau/acr: Fix undefined behavior in nvkm_acr_hsfw_load_bl()

In nvkm_acr_hsfw_load_bl(), the return value of kmalloc() is directly
passed to memcpy(), which could lead to undefined behavior on failure
of kmalloc().

Fix this bug by using kmemdup() instead of kmalloc()+memcpy().

This bug was found by a static analyzer.

Builds with 'make allyesconfig' show no new warnings,
and our static analyzer no longer warns about this code.

Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"")
Signed-off-by: Zhou Qingyang <zhou1615@umn.edu>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220124165856.57022-1-zhou1615@umn.edu
drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c