clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr
authorArnd Bergmann <arnd@arndb.de>
Thu, 11 May 2023 10:58:33 +0000 (12:58 +0200)
committerStephen Boyd <sboyd@kernel.org>
Thu, 15 Jun 2023 00:22:17 +0000 (17:22 -0700)
commit23200a4c8ac284f8b4263d7cecaefecaa3ad6732
treee43ae9ea88536aad33a18eea5552ab1d4bc7e061
parent2a809ddca08d0d1b9ac961815ce04305814e179b
clk: pxa: fix NULL pointer dereference in pxa3xx_clk_update_accr

sparse points out an embarrasing bug in an older patch of mine,
which uses the register offset instead of an __iomem pointer:

drivers/clk/pxa/clk-pxa3xx.c:167:9: sparse: sparse: Using plain integer as NULL pointer

Unlike sparse, gcc and clang ignore this bug and fail to warn
because a literal '0' is considered a valid representation of
a NULL pointer.

Fixes: 3c816d950a49 ("ARM: pxa: move clk register definitions to driver")
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305111301.RAHohdob-lkp@intel.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20230511105845.299859-1-arnd@kernel.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/pxa/clk-pxa3xx.c