[Reassociate] Cleanup minor missed optimizations
authorWarren Ristow <warren.ristow@sony.com>
Thu, 14 Jul 2022 15:21:04 +0000 (08:21 -0700)
committerWarren Ristow <warren.ristow@sony.com>
Thu, 14 Jul 2022 15:21:04 +0000 (08:21 -0700)
commit230c8c56f21cfe4e23a24793f3137add1af1d1f0
tree29b2a88c27bb229af321512386c12274d91aa114
parent486787210df5ce5eabadc90a7de353ae81101feb
[Reassociate] Cleanup minor missed optimizations

In analyzing issue #56483, it was noticed that running `opt` with
`-reassociate` was missing some minor optimizations. For example,
there were cases where the running `opt` on IR with floating-point
instructions that have the `fast` flags applied, sometimes resulted in
less efficient code than the input IR (things like dead instructions
left behind, and missed reassociations). These were sometimes noted
in the test-files with TODOs, to investigate further. This commit
fixes some of these problems, removing some TODOs in the process.

FTR, I refer to these as "minor" missed optimizations, because when
running a full clang/llvm compilation, these inefficiencies are not
happening, as other passes clean that residue up. Regardless, having
cleaner IR produced by `opt`, makes assessing the quality of fixes done
in `opt` easier.
llvm/lib/Transforms/Scalar/Reassociate.cpp
llvm/test/Transforms/Reassociate/fast-ReassociateVector.ll
llvm/test/Transforms/Reassociate/fast-basictest.ll
llvm/test/Transforms/Reassociate/pr42349.ll