Do not widen load for different variable in GVN.
authorDehao Chen <dehao@google.com>
Fri, 9 Sep 2016 18:42:35 +0000 (18:42 +0000)
committerDehao Chen <dehao@google.com>
Fri, 9 Sep 2016 18:42:35 +0000 (18:42 +0000)
commit22ce5eb051591b828b1ce4238624b6e95d334a5b
tree7620ab9e27ab4e5ee5e3fa1d5baf39f4f14ae3d3
parenta5edf655af475d80b83e9b685aea896f0ee2ad18
Do not widen load for different variable in GVN.

Summary:
Widening load in GVN is too early because it will block other optimizations like PRE, LICM.

https://llvm.org/bugs/show_bug.cgi?id=29110

The SPECCPU2006 benchmark impact of this patch:

Reference: o2_nopatch
(1): o2_patched

           Benchmark             Base:Reference   (1)
-------------------------------------------------------
spec/2006/fp/C++/444.namd                  25.2  -0.08%
spec/2006/fp/C++/447.dealII               45.92  +1.05%
spec/2006/fp/C++/450.soplex                41.7  -0.26%
spec/2006/fp/C++/453.povray               35.65  +1.68%
spec/2006/fp/C/433.milc                   23.79  +0.42%
spec/2006/fp/C/470.lbm                    41.88  -1.12%
spec/2006/fp/C/482.sphinx3                47.94  +1.67%
spec/2006/int/C++/471.omnetpp             22.46  -0.36%
spec/2006/int/C++/473.astar               21.19  +0.24%
spec/2006/int/C++/483.xalancbmk           36.09  -0.11%
spec/2006/int/C/400.perlbench             33.28  +1.35%
spec/2006/int/C/401.bzip2                 22.76  -0.04%
spec/2006/int/C/403.gcc                   32.36  +0.12%
spec/2006/int/C/429.mcf                   41.04  -0.41%
spec/2006/int/C/445.gobmk                 26.94  +0.04%
spec/2006/int/C/456.hmmer                  24.5  -0.20%
spec/2006/int/C/458.sjeng                    28  -0.46%
spec/2006/int/C/462.libquantum            55.25  +0.27%
spec/2006/int/C/464.h264ref               45.87  +0.72%

geometric mean                                   +0.23%

For most benchmarks, it's a wash, but we do see stable improvements on some benchmarks, e.g. 447,453,482,400.

Reviewers: davidxl, hfinkel, dberlin, sanjoy, reames

Subscribers: gberry, junbuml

Differential Revision: https://reviews.llvm.org/D24096

llvm-svn: 281074
llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
llvm/test/Instrumentation/AddressSanitizer/asan-vs-gvn.ll
llvm/test/Transforms/GVN/PRE/load-pre-nonlocal.ll
llvm/test/Transforms/GVN/PRE/rle.ll
llvm/test/Transforms/GVN/big-endian.ll
llvm/test/Transforms/GVN/no_speculative_loads_with_asan.ll
llvm/test/Transforms/GVN/pr25440.ll