QCOW2: bug fix - read base image beyond its size
authorChunqiang Tang <ctang@us.ibm.com>
Thu, 3 Feb 2011 15:12:49 +0000 (10:12 -0500)
committerKevin Wolf <kwolf@redhat.com>
Thu, 10 Feb 2011 12:23:44 +0000 (13:23 +0100)
commit22c7441e4c2bfc3803616e6790115e4527464103
tree3fb49fe18a687f023bb5eb1e7a662109b625a46c
parent822deddd9695001bbbae17294641017b19666da3
QCOW2: bug fix - read base image beyond its size

This patch fixes the following bug in QCOW2. For a QCOW2 image that is larger
than its base image, when handling a read request straddling over the end of the
base image, the QCOW2 driver attempts to read beyond the end of the base image
and the request would fail.

This bug was found by Fast Virtual Disk (FVD)'s fully automated testing tool.
The following test triggered the bug.

dd if=/dev/zero of=/var/ramdisk/truth.raw count=0 bs=1 seek=1098561536
dd if=/dev/zero of=/var/ramdisk/zero-500M.raw count=0 bs=1 seek=593099264
./qemu-img create -f qcow2 -ocluster_size=65536,backing_fmt=blksim -b /var/ramdisk/zero-500M.raw /var/ramdisk/test.qcow2 1098561536
./qemu-io --auto --seed=30477694 --truth=/var/ramdisk/truth.raw --format=qcow2 --test=blksim:/var/ramdisk/test.qcow2 --verify_write=true --compare_before=false --compare_after=true --round=100000 --parallel=100 --io_size=10485760 --fail_prob=0 --cancel_prob=0 --instant_qemubh=true

Signed-off-by: Chunqiang Tang <ctang@us.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/qcow2.c
cutils.c
qemu-common.h